Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room scroll state is broken #25810

Closed
greentore opened this issue Jul 15, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#11274
Closed

Room scroll state is broken #25810

greentore opened this issue Jul 15, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#11274
Assignees
@t3chguy
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression

Comments

@greentore
Copy link

Steps to reproduce

Since v1.11.25 of Element (matrix-react-sdk v3.68.0) the scroll state of rooms isn't saved.
Seems like the issue is localized in src/components/structures/RoomView.tsx and caused by this.state.roomId being initialized to undefined instead of null and therefore failing a strict check at line 746.

Steps to reproduce

  1. Open any room and scroll up
  2. Open some other room
  3. Go back the the first room

Outcome

What did you expect?

The scroll state is restored.

What happened instead?

I see the bottom of the room.

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No
@t3chguy t3chguy self-assigned this Jul 17, 2023
@t3chguy
Copy link
Member

t3chguy commented Jul 17, 2023

Regressed by matrix-org/matrix-react-sdk@db6ee53

@t3chguy t3chguy mentioned this issue Jul 17, 2023
Merged
@kittykat kittykat added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jul 20, 2023
@richvdh
Copy link
Member

richvdh commented Jul 20, 2023

Regressed by matrix-org/matrix-react-sdk@db6ee53

ie, matrix-org/matrix-react-sdk#10229

@greentore greentore mentioned this issue Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix room view not properly maintaining scroll position matrix-org/matrix-react-sdk
4 participants
@kittykat @richvdh @t3chguy @greentore