Pile of space member avatars is no longer clickable

[robintown]

Steps to reproduce

1. Go to the home page of a space
2. Click the pile of space member avatars (the ones at the bottom of this screenshot: )
   

Outcome

What did you expect?

The member list for the space should open (this is what it did until recently)

What happened instead?

Nothing happens. I thought that I might be able to work around this by using the Ctrl + . shortcut to open the right panel and show the member list, but that doesn't work either. What does still work is clicking the "3277 members" text, which is apparently (surprisingly!) a button

Operating system

NixOS unstable

Browser information

Firefox 117.0

URL for webapp

develop.element.io

Application version

Element version: 361941e-react-da1daa1b18ff-js-6d118008b6b3 Olm version: 3.2.14

Homeserver

Not relevant

Will you send logs?

No

[manancodes]

@germain-gg I have opened Pull Requests for both the solutions to this problem. Please have a look and let me know if any enhancements are needed. Thanks.

These took time to find the root cause, but it was a fun-to-solve problem.

[manancodes]

I'm not sure I understand why there's two PRs? matrix-org/matrix-react-sdk#11656 seems to already fix the problem?

Moreover the solution here with onClick on a div element is not accessible thus requiring more work. as well as some tests to avoid regressions on this in the future.

@germain-gg The output of these 2 PRs is different.

1. Fix: Clicking on members pile does nothing (Alternate fix) matrix-org/matrix-react-sdk#11656 - If I click on a user icon, the user profile opens up. If I click the more(...) button, the members list opens.(Explained in detail with recordings in the PR itself)

This solution makes more sense to me, but the problem is, hovering over this pile shows a tooltip which says "See all 3357 Members" which makes it confusing and is a bad user experience because only the more(...) button will open the list.

2. Fix: Clicking on members pile does nothing. matrix-org/matrix-react-sdk#11657 - Clicking anywhere on the pile will open the members list. Which is more aligned with the tooltip and the previous implementation before the regression. But again, it is not a complete solution.

Which one should I go ahead with?

Meanwhile I'll research about best workarounds for onClick on non-accessible elements, any assistance or ideas will surely help.

[manancodes]

@robintown @germain-gg Please assist what should I go ahead with?

[germain-gg]

@manancodes matrix-org/matrix-react-sdk#11657 is the desired output, as the tooltip label suggests that you will see all members.