Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OIDC: account management is not directed to OP for statically configured OPs #26305

Closed
kerryarchibald opened this issue Oct 4, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#11723
Closed

OIDC: account management is not directed to OP for statically configured OPs #26305

kerryarchibald opened this issue Oct 4, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#11723
Assignees
@kerryarchibald
Labels
A-Authentication T-Defect Z-Labs

Comments

@kerryarchibald
Copy link
Contributor

Steps to reproduce

  1. Add M_AUTHENTICATION to config.json, using a homeserver that does not have a client/well-known
  2. Authenticate via native OIDC
  3. Go to general settings, expect to see 'your account is managed by OP'

Outcome

What did you expect?

What happened instead?

Current code here relies on client well-known
Use OidcClientStore instead, which falls back to authenticated issuer.

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No
@kerryarchibald kerryarchibald self-assigned this Oct 4, 2023
@kerryarchibald
Copy link
Contributor Author

Fix after #25394

@kerryarchibald kerryarchibald mentioned this issue Oct 8, 2023
Merged
3 tasks
@robintown
Copy link
Member

I'm unsure how to triage this since I don't know what 'OP' refers to, and since there's a fix that's ready to merge, I'll leave it untriaged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kerryarchibald kerryarchibald

Labels
A-Authentication T-Defect Z-Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

OIDC: use delegated auth account URL from OidcClientStore matrix-org/matrix-react-sdk
2 participants
@kerryarchibald @robintown