Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please place config.json in the Debian package somewhere under /etc #26613

Closed
paulvt opened this issue Nov 21, 2023 · 5 comments · Fixed by #26618
Closed

Please place config.json in the Debian package somewhere under /etc #26613

paulvt opened this issue Nov 21, 2023 · 5 comments · Fixed by #26618
Assignees
Labels

Comments

@paulvt
Copy link

paulvt commented Nov 21, 2023

Steps to reproduce

  1. Install the Debian package as described on https://element.io/download

Outcome

What did you expect?

I'd expect the configuration file config.json to be under /etc/element-web or /etc/element-io (or something).
It should be there and maybe just linked to /usr/share/element-web/config.json.
(This is how I had it deployed before the Debian package came into being. Thanks for that!)

What happened instead?

The configuration is under /usr/share/element-web/config.json and thus not manageable by configuration management tools like etckeeper.

Operating system

Debian 12

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

@paulvt paulvt changed the title Please move config.json to /etc Please place config.json in the Debian package somewhere under /etc Nov 21, 2023
@paulvt
Copy link
Author

paulvt commented Nov 21, 2023

This would also have the advantage that config.sample.json could be shipped so I can find out what's new in the config. (Although that should also preferably with the README be under /usr/share/doc/element-web.)

@t3chguy
Copy link
Member

t3chguy commented Nov 21, 2023

/etc/element-web/config.json and /usr/share/doc/element-web are great suggestions - thanks

This would also have the advantage that config.sample.json could be shipped so I can find out what's new in the config.

/usr/share/element-web/config.json is already set up as a conffile, so whenever the config.sample.json changes you'll be shown the diff as part of an apt upgrade

@paulvt
Copy link
Author

paulvt commented Nov 21, 2023

Yes, right, I used to go for a vimdiff before but I guess dpkg will handle that now. I saw that it was already marked as a conffile indeed.

@paulvt
Copy link
Author

paulvt commented Nov 21, 2023

As a side note:
It might be nice to have a "Running from Debian/Ubuntu" in the README and install this to the docs.
Or have and install a separate README.Debian to help the user with: I installed it, now what?
But that's a different issue than this one 😉

@t3chguy
Copy link
Member

t3chguy commented Nov 21, 2023

Yeah this is still very early days, it only shipped mere hours ago :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants