Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context menu for search results in room search dialog is behind the dialog. #26839

Closed
andybalaam opened this issue Jan 9, 2024 · 5 comments · Fixed by #26840
Closed

Context menu for search results in room search dialog is behind the dialog. #26839

andybalaam opened this issue Jan 9, 2024 · 5 comments · Fixed by #26840
Assignees
@t3chguy
Labels
A-Spotlight-Search The new search dialog available in develop and Nightly T-Defect X-Release-Blocker

Comments

@andybalaam
Copy link
Contributor

Steps to reproduce

  1. Open the room search dialog with Ctrl-K
  2. Search for a room name
  3. Click the context menu button "..." on the right of a search result

Outcome

What did you expect?

I expected to see and be able to click the context menu items

What happened instead?

image

The context menu appeared behind the dialog and I was not able to click items in it

Operating system

Ubuntu 22.04

Browser information

Firefox 119.0.1

URL for webapp

https://develop.element.io

Application version

Element version: 922f168-react-82840a19f9ce-js-a597a9d660da Crypto version: Olm 3.2.15

Homeserver

matrix.org

Will you send logs?

No
@andybalaam andybalaam added T-Defect A-Spotlight-Search The new search dialog available in develop and Nightly labels Jan 9, 2024
@t3chguy
Copy link
Member

t3chguy commented Jan 9, 2024 •
edited
Loading

image

Cannot reproduce.

Element version: 922f16812cc2-react-82840a19f9ce-js-a597a9d660da
Crypto version: Olm 3.2.15

@andybalaam
Copy link
Contributor Author

It appears to work fine in Chromium, so I'm guessing this is Firefox-specific.

@t3chguy
Copy link
Member

t3chguy commented Jan 9, 2024

Turns out it only happens if you open a context menu before opening spotlight

@t3chguy t3chguy self-assigned this Jan 9, 2024
@t3chguy t3chguy mentioned this issue Jan 9, 2024
Merged
@andybalaam
Copy link
Contributor Author

Turns out it only happens if you open a context menu before opening spotlight

Nice spot!

@andybalaam
Copy link
Contributor Author

Confirmed fixed; thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Spotlight-Search The new search dialog available in develop and Nightly T-Defect X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix CSS stacking context order determinism element-hq/element-web
2 participants
@andybalaam @t3chguy