Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA not enabled on electron #2787

Closed
ara4n opened this issue Dec 21, 2016 · 15 comments
Closed

GA not enabled on electron #2787

ara4n opened this issue Dec 21, 2016 · 15 comments
Labels
A-Electron P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Dec 21, 2016

This is a huge deal in terms of damaging our stats

@ara4n ara4n added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround P1 A-Electron labels Dec 21, 2016
@ara4n ara4n changed the title GA broken on electron GA not enabled on electron Dec 21, 2016
@ara4n
Copy link
Member Author

ara4n commented Dec 24, 2016

...however, it's also evil for desktop apps to phone home with stats without prompting. Either we prompt (both on web & desktop), or we just ditch GA and infer health of Riot by looking at activity on matrix.org HS.

@4nd3r
Copy link
Contributor

4nd3r commented Dec 25, 2016

not phoning home, but to 3rd party service. and for internal networks, this is absolute no.

@ara4n
Copy link
Member Author

ara4n commented Dec 25, 2016

totally agreed. hence saying we should prompt on both web & desktop. (and switch to somethig better than GA, eg piwik, for which there is another bug).

@ara4n
Copy link
Member Author

ara4n commented Dec 25, 2016

(in practice making stats opt-in is a bit of a disaster though in terms of the metric we need, though, which is how many active users of the app there are, given that directly impacts our funding to work on it :|)

@4nd3r
Copy link
Contributor

4nd3r commented Dec 26, 2016

github download statistics? debian repository statistics? previewable stats (number of accounts in HS, used features eg LDAP login, etc) submission for synapse (and riot-web #2777) which trigger on package upgrades? i would be totally okay with this, because i can verify what information will be sent and when.

@tuxayo
Copy link
Contributor

tuxayo commented Dec 30, 2016

opt-in is a bit of a disaster though in terms of the metric we need, though, which is how many active users of the app there are

Isn't monitoring matrix.org HS enough to know this?

@kythyria
Copy link

kythyria commented Jan 3, 2017

Isn't monitoring matrix.org HS enough to know this?

Not necessarily. An active user might never touch matrix.org at all if they're not in any rooms replicated there.

@rtanalytics
Copy link

What is the bug with Piwik, Matthew?

@jfrederickson
Copy link

Assuming he was referring to #2077

@tuxayo
Copy link
Contributor

tuxayo commented Jan 5, 2017

@kythyria You mean that due to the federated nature of Matrix, monitoring matrix.org will miss many users if other nodes are used massively?

@carlos22
Copy link

(in practice making stats opt-in is a bit of a disaster though in terms of the metric we need, though, which is how many active users of the app there are, given that directly impacts our funding to work on it :|)

That is a drastic statement and means it is more important for you to know how many users you have and what they are doing, then respecting their privacy. I get the point, but you should really consider not doing analytics at all! Because if you want this thing to succeed you need to offer more than just another slack/telegram whatever. We have a lot of messengers that have their problems in terms of privacy, data-collection and openness. Please do not enter that road.

But maybe that dream of such a project is impossible with venture capital backing...

@tuxayo
Copy link
Contributor

tuxayo commented Jan 18, 2017

That is a drastic statement and means it is more important for you to know how many users you have and what they are doing, then respecting their privacy.

If that directly affects whether or not they can work on Matrix/Riot so yes the developers must value this more than anything else.
But considering there work on end-to-end encryption and the worries about the privacy consequences of GA, they definitely care about privacy.

That's doesn't diminish the importance of the issue: how to reliably get the number of active users of a federate network in a privacy friendly way?

Switching from Google Analytic to something else would already be a huge improvement.

But maybe that dream of such a project is impossible with venture capital backing...

Amdocs doesn't seem to be venture capital backed so that is not the issue here. Well it's still a publicly traded company.

@ara4n
Copy link
Member Author

ara4n commented Jan 18, 2017

the conclusion here is that we're certainly not enabling GA on electron by default, and we're going to make it opt-in on both electron & web, which is #2075. So closing this a dup.

@ara4n ara4n closed this as completed Jan 18, 2017
@ara4n
Copy link
Member Author

ara4n commented Jan 18, 2017

oh, and for the record, we're not so concerned about somehow instrumenting the whole size of the matrix network - just wanting to estimate how many Riot DAU there are based on the number we can see from the server logs on matrix.org, and the overall size of the matrix.org ecosystem as seen by the number of Matrix servers visible from matrix.org & synapse's opt-in phone-home stats. So there really is no need to be using GA; the only reason we're doing is historical and not having to 'round to removing it yet, as fixing bugs in the app takes priority over maintenance of the analytics lib.

@tuxayo
Copy link
Contributor

tuxayo commented Jan 20, 2017

Thanks a lot for taking the time to respond to all these concerns, it good to have devs that care for their most privacy conscious users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Electron P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

6 participants