Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some controls are not disable while the sign-in dialog is loading #27907

Closed
Johennes opened this issue Aug 7, 2024 · 0 comments · Fixed by matrix-org/matrix-react-sdk#12895
Closed

Some controls are not disable while the sign-in dialog is loading #27907

Johennes opened this issue Aug 7, 2024 · 0 comments · Fixed by matrix-org/matrix-react-sdk#12895
Assignees
@t3chguy
Labels
A-Login O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Fixed-By-OIDC Issues which can be closed when we move to OIDC

Comments

@Johennes
Copy link
Contributor

Johennes commented Aug 7, 2024

Steps to reproduce

  1. Open app.element.io
  2. Enter your username and password
  3. Start the sign-in process
  4. Notice how some controls on the page are disabled while others are not

Outcome

What did you expect?

All controls are disabled.

What happened instead?

The controls to change the home server or start SSO login were enabled.

image

image

image

Operating system

fedora Linux 40

Browser information

Firefox 128.0.3

URL for webapp

app.element.io

Application version

  • (cannot access before signing in)

Homeserver

matrix.org

Will you send logs?

No
@dosubot dosubot bot added A-Login S-Minor Impairs non-critical functionality or suitable workarounds exist labels Aug 7, 2024
@t3chguy t3chguy added the Z-Fixed-By-OIDC Issues which can be closed when we move to OIDC label Aug 8, 2024
@dbkr dbkr added the O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience label Aug 9, 2024
@t3chguy t3chguy self-assigned this Aug 16, 2024
@t3chguy t3chguy mentioned this issue Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Login O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Fixed-By-OIDC Issues which can be closed when we move to OIDC
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure elements on Login page are disabled when in-flight matrix-org/matrix-react-sdk
3 participants
@dbkr @Johennes @t3chguy