Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit the number of concurrent preview url requests #3106

Closed
kegsay opened this issue Feb 1, 2017 · 1 comment
Closed

Limit the number of concurrent preview url requests #3106

kegsay opened this issue Feb 1, 2017 · 1 comment
Labels
A-Performance A-URL-Previews P2 T-Defect

Comments

@kegsay
Copy link
Contributor

kegsay commented Feb 1, 2017

I noticed that I had no avatar images loading in riot-web and then /sync requests were being client side timed out. Logs showed 504 timeouts from preview url requests. It turns out that Riot had done lots of these preview url requests and they all wedged like that, starving the rest of the app from making any connections. We should put a cap on the max requests that we will make to /preview_url
@MadLittleMods
Copy link
Contributor

Closing in favor of #7292

Related to #10555 and #14998

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Performance A-URL-Previews P2 T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MadLittleMods @ara4n @kegsay