Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When invites fail, we lose the error message #3283

Closed
ara4n opened this issue Feb 21, 2017 · 1 comment · Fixed by matrix-org/matrix-react-sdk#2317
Closed

When invites fail, we lose the error message #3283

ara4n opened this issue Feb 21, 2017 · 1 comment · Fixed by matrix-org/matrix-react-sdk#2317
Assignees
@turt2live
Labels
P2 S-Tolerable Low/no impact on users T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Feb 21, 2017

Invite.js's multiinvite stuff builds up a nice list of error reasons, which are then lost by the time they're displayed in _showAnyInviteErrors in ChatInviteDialog.js
@ara4n ara4n added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround P2 ui/ux S-Tolerable Low/no impact on users and removed S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Feb 21, 2017
@lampholder lampholder mentioned this issue May 30, 2018
Closed
@turt2live turt2live self-assigned this Nov 27, 2018
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Nov 29, 2018
@turt2live
Check if users exist before inviting them and communicate errors
987ad0b 
Fixes element-hq/element-web#3283
Fixes element-hq/element-web#3968
Fixes element-hq/element-web#4308
Fixes element-hq/element-web#1597
Fixes element-hq/element-web#6790

This does 3 things:
* Makes the `MultiInviter` check for a user profile before attempting an invite. This is to prove the user exists.
* Use the `MultiInviter` everywhere to avoid duplicating the logic. Although a couple places only invite one user, it is still worthwhile.
* Communicate errors from the `MultiInviter` to the user in all cases. This is done through dialogs, where some existed previously but were not invoked.

Specifically to the 403 error not working: What was happening was the `MultiInviter` loop was setting the `fatal` flag, but that didn't resolve the promise it stored. This caused a promise to always be open, therefore never hitting a dialog.
@turt2live turt2live mentioned this issue Nov 29, 2018
Merged
@turt2live
Copy link
Member

Fixed by matrix-org/matrix-react-sdk#2317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
P2 S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check if users exist before inviting them and communicate errors matrix-org/matrix-react-sdk
2 participants
@turt2live @ara4n