Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Proposal to simplify key verifications #3772

Closed
glaxx opened this issue Apr 29, 2017 · 5 comments
Closed

Design Proposal to simplify key verifications #3772

glaxx opened this issue Apr 29, 2017 · 5 comments
Labels

Comments

@glaxx
Copy link

glaxx commented Apr 29, 2017

Description

In "Settings - CRYPTOGRAPHY" where your device key is listed, the font should be a monospaced for easier and less error prone device verification. Furthermore the fingerprint should be (visually) separated by dashes.

Current State: (This "fingerprint" is an example)

Device Key: hWTyfybz46DYdYcsJnQvKZ2SKJYUavRax8B6oLbp4VP

Proposed Change:

Device Key: hWT-yfybz46DYd-YcsJnQvKZ2-SKJYUavRax-8B6oLbp4VP

hWT-yfybz46DYd-YcsJnQvKZ2-SKJYUavRax-8B6oLbp4VP
0                                            42

Steps to reproduce

Does not apply.

Version information

  • Platform: web
    For the web app:

  • Browser: chromium 58.0.3029.81 (64-bit)

  • OS: Arch Linux

  • URL: riot.im

@lampholder
Copy link
Member

Thanks for the suggestion - it looks to me like the device key already is monospaced (it looks like it's set in the css, and appears monospaced on Chrome on my mac).

Visually separating the key with cosmetic dashes is an interesting idea - is there a particular rationale for the 3-10-10-10-10 breakdown over another pattern?

@lampholder lampholder added S-Tolerable Low/no impact on users feature P3 labels May 1, 2017
@glaxx
Copy link
Author

glaxx commented May 4, 2017

Regarding the font: Oh. I probably was just to blind/drunk (or so haha) to recognize it as an monospaced font.

The 3-10-10-10-10 pattern was/is just an try to get 43 (which is a prime number) letters divided into nice, not too long slices which I guess would also improve readability.

@uhoreg
Copy link
Member

uhoreg commented May 4, 2017

#2142 is the issue for improving key verification

@uhoreg
Copy link
Member

uhoreg commented Jun 24, 2017

The key has been separated into groups of 4 (plus one group of 3), so I think this is closable now.

@uhoreg uhoreg closed this as completed Jun 24, 2017
@glaxx
Copy link
Author

glaxx commented Jun 26, 2017

Awesome! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants