Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We do not encrypt messages proactively for invited users who have yet to join. #3821

Closed
ara4n opened this issue May 5, 2017 · 4 comments
Closed

Comments

@ara4n
Copy link
Member

ara4n commented May 5, 2017

This is a problem for encrypted 1:1s, where it's a common idiom that I'd start a 1:1, make it encrypted, send a secret message, and wait for the other person to accept the invite and answer it -
except right now we don't encrypt these pre-invite messages.

As I understand it, the sender client just needs to check the history visibility settings for a room when issuing an invite, and encrypt appropriately. If the target user doesn't exist or has no devices, then we fall back on element-hq/element-meta#647 to resolve things.

@ara4n
Copy link
Member Author

ara4n commented Jul 19, 2017

increasing the priority as (proportionally speaking) this is starting to be a major cause of UISIs for me

@ara4n
Copy link
Member Author

ara4n commented Nov 23, 2017

#2713 is an alt approach.

@ara4n ara4n added the tracker label Dec 13, 2017
@ara4n
Copy link
Member Author

ara4n commented Mar 29, 2019

This is almost done, other than the edge case that if the invited user adds a device after being invited, their new device will not be encrypted for as we have no way to know about new devices as they aren't yet participating in the room.

The solution is to let them participate in the room to some extent before joining - perhaps by having the server join the room on their behalf via a @:server user or similar, same as we might use for peeking over federation (matrix-org/matrix-spec-proposals#1777)

@t3chguy
Copy link
Member

t3chguy commented Mar 31, 2023

This got done

@t3chguy t3chguy closed this as completed Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants