Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inviting someone already in room fails blindly #3968

Closed
t3chguy opened this issue May 19, 2017 · 4 comments · Fixed by matrix-org/matrix-react-sdk#2317
Closed

inviting someone already in room fails blindly #3968

t3chguy opened this issue May 19, 2017 · 4 comments · Fixed by matrix-org/matrix-react-sdk#2317
Assignees
@turt2live
Labels
P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@t3chguy
Copy link
Member

t3chguy commented May 19, 2017

no way of knowing what happened without looking at the error in network tab of dev tools
@lampholder lampholder added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist P2 ui/ux labels May 22, 2017
@lampholder
Copy link
Member

I'm not sure what the best fix to this would look like - our options seem to be:

  • something in the message pane (an event maybe saying 'X was not invited because they are already present in the room'), or
  • a modal popup saying something similar

Both seem quite... big for something you could safely ignore. Thoughts?

@t3chguy
Copy link
Member Author

t3chguy commented May 22, 2017

Agreed, did confuse me for a good 60 seconds before I figured out the person was already in the room

@lampholder lampholder mentioned this issue May 30, 2018
Closed
@turt2live turt2live self-assigned this Nov 27, 2018
@turt2live
Copy link
Member

worth noting that this doesn't apply if someone uses the /invite command rather than the dialog.

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Nov 29, 2018
@turt2live
Check if users exist before inviting them and communicate errors
987ad0b 
Fixes element-hq/element-web#3283
Fixes element-hq/element-web#3968
Fixes element-hq/element-web#4308
Fixes element-hq/element-web#1597
Fixes element-hq/element-web#6790

This does 3 things:
* Makes the `MultiInviter` check for a user profile before attempting an invite. This is to prove the user exists.
* Use the `MultiInviter` everywhere to avoid duplicating the logic. Although a couple places only invite one user, it is still worthwhile.
* Communicate errors from the `MultiInviter` to the user in all cases. This is done through dialogs, where some existed previously but were not invoked.

Specifically to the 403 error not working: What was happening was the `MultiInviter` loop was setting the `fatal` flag, but that didn't resolve the promise it stored. This caused a promise to always be open, therefore never hitting a dialog.
@turt2live turt2live mentioned this issue Nov 29, 2018
Merged
@turt2live
Copy link
Member

Fixed by matrix-org/matrix-react-sdk#2317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check if users exist before inviting them and communicate errors matrix-org/matrix-react-sdk
3 participants
@turt2live @lampholder @t3chguy