Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing the electron Riot.im non-obviously minimises it to the system tray rather than properly closing it. #4628

Closed
lampholder opened this issue Jul 18, 2017 · 10 comments
Labels
A-Electron P2 Z-Rageshake Has attached rageshake (not for log submission process)

Comments

@lampholder
Copy link
Member

I would expect it to close the application.

@lampholder lampholder added feature Z-Rageshake Has attached rageshake (not for log submission process) A-Electron P4 [OBSOLETE LABEL] Interesting — Not yet scheduled, will accept patches and removed feature labels Jul 18, 2017
@lampholder
Copy link
Member Author

We might want this to be configurable? And/or (on first close/minimise) pop up a message explaining what's happened?

@ArchangeGabriel
Copy link

This is standard behaviour for a lot of apps, but I agree it could be made configurable.

@t3chguy
Copy link
Member

t3chguy commented Sep 9, 2017

I already have an IPC for configuration of the electron main process from the renderer, so just need to add persistence and then this'll be painless

@fuzzy76
Copy link

fuzzy76 commented Sep 11, 2017

For OS X the normal behaviour is closing the window, but keeping the app running. Which is what is does now. :)

@AaronBPaden
Copy link

A system tray is also not guaranteed to exist on Linux. It doesn't on gnome now. Riot should automatically detect this case and Do The Right Thing™.

@lampholder
Copy link
Member Author

Related: #3133

@lampholder lampholder added ui/ux P2 and removed P4 [OBSOLETE LABEL] Interesting — Not yet scheduled, will accept patches labels Apr 16, 2018
@eleius
Copy link

eleius commented Feb 16, 2019

I have this problem in Gnome. No tray icon so I cannot close Riot (I have to kill the process, or start it from the terminal and use ctrl-c to exit).

@xoxys
Copy link

xoxys commented Jul 22, 2019

Also, closing with Menu -> Close does not force close Riot on gnome/fedora. And that's a default behavior in MacOS as I know... There has to be a way to force close a UI application without killing the process on cli. That's a bit messy and should be fixed

@t3chguy
Copy link
Member

t3chguy commented Aug 5, 2019

This is configurable:

image

@532910
Copy link
Contributor

532910 commented Aug 5, 2019

ack. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Electron P2 Z-Rageshake Has attached rageshake (not for log submission process)
Projects
None yet
Development

No branches or pull requests

9 participants