Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White background on .mx_BaseAvatar_image makes dark profile pictures look terrible on dark theme #4712

Closed
Qwertie- opened this issue Jul 31, 2017 · 4 comments
Labels
A-Avatar A-Theming P2 S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users T-Defect

Comments

@Qwertie-
Copy link

When you have a profile picture with a black edge it gets a very thin white border around the image which looks quite bad against the black background of riot.

I assume this is here to make images with transparency visible on all background colors but I would argue that having no default background lets those groups set an icon with a proper background color where as the current setup makes it impossible to have a good looking icon on dark themes.

The background color really should not be visible on the edges of an image with no transparency though.

@turt2live
Copy link
Member

Related / possible duplicate of #3203

@lampholder
Copy link
Member

The image in #3203 seems to show the halo in the typing-notification-avatar rather than the inline-with-message-text avatar, so these can stay separate for now (though I expect they are closely linked and would be dealt with simultaneously).

@lampholder lampholder added T-Defect S-Tolerable Low/no impact on users S-Minor Impairs non-critical functionality or suitable workarounds exist P2 A-Theming labels Aug 1, 2017
@turt2live
Copy link
Member

This also affects transparent avatars. Relayed from #riot (starting at https://matrix.to/#/!DgvjtOljKujDBrxyHk:matrix.org/$15041096531463006EUJlK:matrix.org)

there is a white bg behind my profile picture for some reason, which kind of defeats the point of supporting transparency in profile pictures
if someoen thinks their icon might look bad with transparency enabled they schouldnt enable it :/

Their avatar in question is 100% transparent: https://t2l.io/_matrix/media/v1/thumbnail/matrix.org/KmaJJyCiQMOqIBYSqebjYFzG?width=30&height=30&method=crop

@robintown
Copy link
Member

Closing as both the dark and transparent cases have been fixed for some time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Avatar A-Theming P2 S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Development

No branches or pull requests

5 participants