Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pillifying removes character before Pill #4855

Closed
t3chguy opened this issue Aug 23, 2017 · 2 comments
Closed

Pillifying removes character before Pill #4855

t3chguy opened this issue Aug 23, 2017 · 2 comments
Labels
P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@t3chguy
Copy link
Member

t3chguy commented Aug 23, 2017

so (Travis [TAB] results in Pill but ( goes away :(

@lampholder lampholder added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist P1 labels Aug 24, 2017
@lukebarnard1
Copy link
Contributor

This seems unique to \S characters, that is characters that are not considered whitespace. And this only happens when tab completing, so

if (force && this.shouldForceComplete()) {
        commandRegex = /\S+/g;
}

is looking suspect.

This means that when tab-completing, the regex changes from @\S* to \S+ for the UserProvider (the thing providing user completions). \S+ will go and match anything before the display name entered that isn't whitespace.

This is a side-effect of tab-completing free-form text to free-form, arbitrary display names.

@ara4n
Copy link
Member

ara4n commented Jul 16, 2018

fixed in matrix-org/matrix-react-sdk#1890

@ara4n ara4n closed this as completed Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

4 participants