Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transparent avatars on the LLP are green now (when selected) #6305

Closed
turt2live opened this issue Mar 13, 2018 · 6 comments
Closed

Transparent avatars on the LLP are green now (when selected) #6305

turt2live opened this issue Mar 13, 2018 · 6 comments
Labels
A-Avatar P2 S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users T-Defect X-Needs-Design

Comments

@turt2live
Copy link
Member

Description

They used to be white.
image

Version information

  • Platform: web (in-browser)
  • Browser: Chrome 64
  • OS: Windows 10
  • URL: riot.im/develop
@turt2live
Copy link
Member Author

32 bit. This is specifically caused by #6290

@lampholder
Copy link
Member

Blue if you're on the status theme :P

Is this necessarily a problem? Or were you just flagging it because it is a possibly unintentional change?

@lampholder lampholder added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users design P2 labels Mar 13, 2018
@lampholder lampholder changed the title Transparent avatars on the LLP are green now Transparent avatars on the LLP are green now (when selected) Mar 13, 2018
@turt2live
Copy link
Member Author

I feel relatively strongly that this should be fixed for 0.14. Particularly considering the backgrounds are white when not selected, and then suddenly different. To demonstrate this problem, here's the difference of having nothing selected and all of them selected:

image

@ara4n
Copy link
Member

ara4n commented Feb 6, 2019

@turt2live did this get fixed?

@turt2live
Copy link
Member Author

Nope
image

@ara4n ara4n mentioned this issue Feb 6, 2019
Closed
@aaronraimist
Copy link
Collaborator

This seems to be fixed now

@t3chguy t3chguy closed this as completed Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Avatar P2 S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users T-Defect X-Needs-Design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@jryans @turt2live @ara4n @lampholder @t3chguy @aaronraimist and others