Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room list tag state change on drag and drop is glitchy. #6369

Closed
lampholder opened this issue Mar 21, 2018 · 8 comments
Closed

Room list tag state change on drag and drop is glitchy. #6369

lampholder opened this issue Mar 21, 2018 · 8 comments
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression

Comments

@lampholder
Copy link
Member

Dragging roomtiles from one section to another results in their having the wrong tag.

@lampholder lampholder added T-Defect P1 X-Regression S-Major Severely degrades major functionality or product features, with no satisfactory workaround X-Release-Blocker labels Mar 21, 2018
@lampholder
Copy link
Member Author

My starting setup was:

INVITES
(#) Test Room
FAVOURITES
(#) Matrix HQ
PEOPLE
(#) Riot-bot

I dragged Matrix HQ from FAVOURITES to PEOPLE, then I waited for a bit, then Matrix HQ ended up in ROOMS.

Further dragging and dropping caused similar unpredictable behaviour.

@lampholder lampholder changed the title Dragging rooms between sections in the roomlist is very glitchy. Room list tag state change on drag and drop is glitchy. Mar 21, 2018
@lukebarnard1
Copy link
Contributor

@lampholder
Copy link
Member Author

I've found another problem in a similar space (which maybe should be a separate bug but I'm putting it here for now):

If you're roomlist looks like this:
selection_017

And you drag Riot onto the "You're not in any rooms yet!' landing rectangle, it gets stuck on the ROOMS header like this:
selection_018

It fails with this error:
selection_019

@lampholder
Copy link
Member Author

Also I noticed that you can't drag into historical, but it turns out you can't do that on /app, either.

@lukebarnard1
Copy link
Contributor

FTR: Same bug

@lampholder
Copy link
Member Author

The room list is a mess of UX paradigms - four headings that look the same (five if you count invites) and they all work a little bit differently.

INVITES - No dragging; disappear after accepting/rejecting
FAVOURITES - Drag within the list to set order manually. Drag outside of list to change DM/not DM, Favourite/Not Favourite and Low Priority/Not Low Priority state.
PEOPLE - rooms end up here based upon unclear (to the user) heuristics. No dragging within list. Drag outside of list to change DM/not DM, Favourite/Not Favourite and Low Priority/Not Low Priority state. Ordered by most recent activity.
ROOMS & LOW PRIORITY - No dragging within list. Drag outside of list to change DM/not DM, Favourite/Not Favourite and Low Priority/Not Low Priority state. Ordered by activity.
HISTORICAL - No dragging of any sort, in or out.

Add to that that some transitions don't work - this is clearly an area that needs some attention 😄

@lampholder
Copy link
Member Author

The wider scope of this issue wasn't a release blocker in the end - they were issues that had been in place from before 0.14 (and I didn't want to block 0.14 on their resolution).

@turt2live
Copy link
Member

Closing in favour of #8614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression
Projects
None yet
Development

No branches or pull requests

3 participants