My historical section is missing

[turt2live]

Description

Version information

• Platform: web (in-browser)
• Browser: Chrome 67
• OS: Windows 10
• URL: riot.im/develop

[lampholder]

I'm not sure what we want the behaviour to be exactly - I appreciate the clarity of empty headers being invisible, especially when I filter by community, but at the moment we allow users to change a room's dm/room favourite/low-priority status by dragging and that's only possible with a drag target.

[t3chguy]

@lampholder those won't vanish because the droptarget means the roomsublist is not empty, but the Historical roomsublist had no text/anything when it was empty, only a Spinner when you clicked on it which yielded either rooms or empty space

[t3chguy]

oh I see what you mean, they can vanish when querying by searchFilter/TagPanel, so its a different break than Historical

[turt2live]

In the screenshot there's no filtering whatsoever going on. The section used to be there, but it disappeared some time yesterday.

[t3chguy]

After discussion, this behaviour is going behind an opt-in flag as well as fixing Historical when it is enabled

[turt2live]

Is this actually a feature? I'm a bit concerned that the actual bug is lost in translation.

[t3chguy]

No sorry probably my bad explanation.
The roomsublist auto-hide behaviour will be opt-in,
Your bug is about the roomsublist-auto-hide behaviour, the PR above fixes the bug
but the behaviour as a whole will still be opt-in

[turt2live]

There is no PR above. Way above, got it.

[t3chguy]

matrix-org/matrix-react-sdk#2016

[t3chguy]

Faaaaar above

[turt2live]

When was this introduced? It seemed like an unintended bug which is why I reported it. I don't actually mind the behaviour.

[t3chguy]

matrix-org/matrix-react-sdk#1954

[t3chguy]

it is unintended