Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom homeserver URL doesn't behave sensibly if no protocol is specified. #7706

Closed
lampholder opened this issue Nov 15, 2018 · 3 comments · Fixed by matrix-org/matrix-react-sdk#5474
Assignees
Labels
A-Login A-Registration P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@lampholder
Copy link
Member

image

If you don't specify a protocol (http/https) for the custom homeserver URL, Riot just assembles the URL it's poking as a relative path (so if you're using https://riot.im/app and you put in the domain example.com then it will poll https://riot.im/app/example.com/_matrix/client/r0/login - in the case of https://riot.im it'll get a 404, but that'll obviously depend on the particular configuration of the server serving the riot web client.

It would probably be best to validate on the presence of a protocol and if it's not there tell the user to correct their URL.

@lampholder lampholder added T-Defect P2 S-Minor Impairs non-critical functionality or suitable workarounds exist A-Registration A-Login labels Nov 15, 2018
@lampholder
Copy link
Member Author

#7651

@aaronraimist
Copy link
Collaborator

Note that this issue is applies to every(?) URL field in RIot. See #6333 for another example, specifically

If you leave off the https:// and simply type "myserver.com" for the id server, you are shown the screen that says an email confirmation has been sent.

@turt2live turt2live self-assigned this May 2, 2019
@turt2live
Copy link
Member

@lampholder should we just make this do .well-known when someone does this? As per #8310 I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Login A-Registration P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants