Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't notify unless the user was explicitly mentioned (pill) #9302

Closed
lapin-b opened this issue Mar 27, 2019 · 4 comments
Closed

Don't notify unless the user was explicitly mentioned (pill) #9302

lapin-b opened this issue Mar 27, 2019 · 4 comments

Comments

@lapin-b
Copy link

lapin-b commented Mar 27, 2019

Description

In a few words, whenever someone answers a message from somebody else, I get notified becasue my username is in my domain name. For example, when @userb:usera.website answers to @userc:usera.website, @usera:usera.website gets notified.

Here's a more visual example of what's happening:

image

I'm mentioned and notified despite the answer not being directed at me.

Steps to reproduce

Take the example case from abose. If needed, I can add a list of steps to follow to reproduce the case.

What's expected: I shouldn't get notified when an answer is directed at someone else despite my username appearing in my domain name.

Log: not relevant

Version information

  • Platform: Desktop and web app

Web app

  • Browser: Firefox 66.0.1
  • OS: Arch Linux, kernel version 5.0.3 (if that matters)
  • URL: Self hosted chat, version 1.0.5

Desktop app

  • OS: Arch Linux, kernel version 5.0.3 (if that matters)
  • Version: 1.0.5
@turt2live turt2live changed the title Mention and notification because of username in domain name Don't notify unless the user was explicitly mentioned (pill) Apr 2, 2019
@turt2live
Copy link
Member

Have altered the title to adopt this as the canonical "notifications shouldn't do anything unless I'm mentioned" issue.

@grinapo
Copy link

grinapo commented Dec 5, 2020

I think the current categories are "flawed" or not complete.

A user is called "dolphin" using @elephant:kangaroo.net.

  • match on display name matches anything containing the string "dolphin"
  • match on username seems to match on anything containing "elephant"

However:

  • match on display name will erroneously match on "bob" @will:dolphin.net, or "jane" @dolphin:racoon.org
  • match on username will err match on "joe" @sam:elephant.com, "elephant" @snake.fi

So

  • there is no "match on mxid" option, which only would match "@elephant:kangaroo.net" string, pill or else

And in an ideal world

  • display name match should not match on hostname substrings
  • username likewise shall not match on hostname substrings

@t3chguy
Copy link
Member

t3chguy commented May 10, 2022

Duplicate of #8431

@t3chguy t3chguy marked this as a duplicate of #8431 May 10, 2022
@t3chguy t3chguy closed this as completed May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants