Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI trial runs annotated with Signatures do not match #10942

Open
matrixbot opened this issue Dec 19, 2023 · 0 comments
Open

CI trial runs annotated with Signatures do not match #10942

matrixbot opened this issue Dec 19, 2023 · 0 comments

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 19, 2023

This issue has been migrated from #10942.


  1. GHA invokes trial which runs the test tests.handlers.test_oidc.OidcHandlerTestCase.test_callback_session.
  2. This encounters debug logging added in Dummy issue #9307. This uses logger.exception which writes a traceback to synapse's log. It will eventually appear in the test output when trial summaries the test run. (Unclear if this is on stdout or stderr)
  3. We use actions/setup-python which sets up a problem matcher that looks for tracebacks ending in a raise statement containing a string literal.
  4. The (intentionally-logged) tracebacks end up getting flagged as a scary annotation. But this is a false positive.

image

Suggestions:

  • Remove the logger.exception if we don't need it any more
  • Log something else that's useful but which won't trigger the problem matcher
  • Setup test logging config to suppress logging.exceptions in this module

(Surprised this hasn't caught annotated more exceptions in the logs tbh---perhaps the regex only detects single-quoted string literal exception messages?)

@matrixbot matrixbot changed the title Dummy issue CI trial runs annotated with Signatures do not match Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant