Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Requested operation has changed during the UI authentication session." shouldn't be raised if only the query string changes #7722

Open
matrixbot opened this issue Dec 17, 2023 · 0 comments

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 17, 2023

This issue has been migrated from #7722.


matrix-org/synapse#7483 changed the condition under which the "Requested operation has changed during the UI authentication session." error raised so that it's only raised if the (method, uri) changes during UIA.

This means that if e.g. I initiate a registration with POST /register but ends it with POST /register?kind=user, which is the same operation, the registration fails.

Ideally this condition should be changed to omit the query string from the uri, but we should first check if that doesn't introduce any issue (e.g. if the UIA operation is passed in the query string in some cases - which I don't think it is, but we should probably make sure of that).

@matrixbot matrixbot changed the title Dummy issue "Requested operation has changed during the UI authentication session." shouldn't be raised if only the query string changes Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant