Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/createRoom creates an empty room when there is an error sending events #8895

Open
matrixbot opened this issue Dec 18, 2023 · 0 comments
Open

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 18, 2023

This issue has been migrated from #8895.


If somehow your createRoom request is too large, like if for example you send a base64 encoded avatar instead of an mxc URL (wrongly) then the request fails with a 413 but a new Empty room is created and sent to the user with none of the parameters the user asked for.

Example request payload:

{
  "visibility": "public",
  "name": "Test Space 17",
  "creation_content": {
    "type": "m.space"
  },
  "initial_state": [
    {
      "type": "m.room.avatar",
      "content": {
        "avatar": "data:image/png;base64,iVBOR..............AAAAASUVORK5CYII="
      }
    },
    {
      "type": "m.room.guest_access",
      "state_key": "",
      "content": {
        "guest_access": "can_join"
      }
    }
  ],
  "power_level_content_override": {
    "events_default": 100
  },
  "preset": "private_chat"
}

(avatar truncated Github would not let me post)

image

Expectation: Empty room is not created.

Possibly related to matrix-org/synapse#8625 but am operating in Monolith mode.

@matrixbot matrixbot changed the title Dummy issue /createRoom creates an empty room when there is an error sending events Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant