Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Manage Web Apps" page with no web apps shows broken icon #1196

Closed
ryonakano opened this issue Apr 29, 2023 · 1 comment · Fixed by #1197
Closed

"Manage Web Apps" page with no web apps shows broken icon #1196

ryonakano opened this issue Apr 29, 2023 · 1 comment · Fixed by #1197
Assignees
@danirabbit

Comments

@ryonakano
Copy link
Contributor

ryonakano commented Apr 29, 2023 •
edited
Loading

What Happened?

I'm not sure I should report this to which the browser repository or the icons repository; feel free to transfer this if it's in wrong place.

The web apps page with no web apps has broken icon above the "Apps" title label:

スクリーンショット 2023-04-30 07 17 32

Steps to Reproduce

I'm using Web 44.2 (which elementary ships)

ryo@lb450m:~$ flatpak run org.gnome.Epiphany --version
Web 44.2
ryo@lb450m:~$
  1. Open Web
  2. Click the gear button at the top right and open "Main Menu", then select "Manage Web Apps"
  3. Remove all installed web apps if exist, and then reload the page
  4. See the icon missing in the center of the page

Expected Behavior

The icon should be shown.

I investigated with the developer tools and looks like the icon shows blank path file://

スクリーンショット 2023-04-30 07 22 16

Looking at the code, I guess we're missing the application-x-addon-symbolic icon and thus the path is set to file://:

ryo@lb450m:~/work/tmp/epiphany ((44.2))$ vim embed/ephy-about-handler.c
……

326     GtkIconTheme *icon_theme;
327     g_autoptr (GtkIconPaintable) paintable = NULL;
328     g_autofree char *path = NULL;
329 
330     g_string_append_printf (data_str, "<html><head><title>%s</title>"
331                             "<meta http-equiv=\"Content-Type\" content=\"text/html; charset=utf-8\" />"
332                             "<link href=\""EPHY_PAGE_TEMPLATE_ABOUT_CSS "\" rel=\"stylesheet\" type=\"text/css\">"
333                             "</head><body class=\"applications-body\">",
334                             _("Apps"));
335 
336     icon_theme = gtk_icon_theme_get_for_display (gdk_display_get_default ());
337     paintable = gtk_icon_theme_lookup_icon (icon_theme,
338                                             "application-x-addon-symbolic",
339                                             NULL,
340                                             128,
341                                             1,
342                                             GTK_TEXT_DIR_LTR,
343                                             0);
344 
345     if (paintable) {
346       g_autoptr (GFile) file = gtk_icon_paintable_get_file (paintable);
347 
348       path = g_file_get_path (file);
349     }
350 
351     g_string_append_printf (data_str,
352                             "  <div id=\"overview\" class=\"overview-empty\">\n"
353                             "    <img src=\"file://%s\"/>\n"
354                             "    <div><h1>%s</h1></div>\n"
355                             "    <div><p>%s</p></div>\n"
356                             "  </div>\n"
357                             "</body></html>\n",
358                             path ? path : "",
359                             /* Displayed when opening applications without any installed web apps. */
360                             _("Apps"), _("You can add your favorite website by clicking <b>Install as Web App…</b> within the page menu."));
361   }

OS Version

7.x (Horus)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

  • CPU: AMD Ryzen 5 3400G
  • RAM: 16 GB
  • Graphics: iGPU
  • Storage: 490 GB NVMe SSD
@danirabbit
Copy link
Member

Ah yeah this seems like probably an issue for the icons repo. Woops

@danirabbit danirabbit transferred this issue from elementary/browser Apr 30, 2023
@danirabbit danirabbit mentioned this issue May 1, 2023
Merged
@danirabbit danirabbit self-assigned this May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danirabbit danirabbit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extension → application-x-addon elementary/icons
2 participants
@danirabbit @ryonakano