Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latin-ext subset for Google Fonts in case of sk_SK (and others) locale #9660

Closed
2 tasks done
andrejm opened this issue Nov 22, 2019 · 5 comments
Closed
2 tasks done
Labels
control/group/typography References the Typography group settings control. status/merged Indicates when a Pull Request has been merged to a Release.
Milestone

Comments

@andrejm
Copy link
Contributor

andrejm commented Nov 22, 2019

Prerequisites

  • I have searched for similar features requests in both open and closed tickets and cannot find a duplicate.
  • The feature is still missing in the latest stable version of Elementor ( Elementor Pro. )

What problem is your feature request going to solve? Please describe.
Some languages need special characters present in latin-ext subsets of Google Fonts. If the font is loaded without this subset, rendered page looks really nasty with missing letters shown in default font.

Describe the solution you'd like
Simply adding 'sk_SK' => 'latin-ext' for Slovak locale in print_google_fonts() function in includes/frontend.php

Describe alternatives you've considered
A filter hook to set particular subset

Additional context
I think many others would like to see their languages added - see #1630 comments, #8186, #1915

@ogio
Copy link

ogio commented Mar 15, 2020

Yes, we need this ASAP because Latin Extemded and Cyrillic subsets needs to be used for Eastern Europe and wider. Please, for now it will be helpful that we have some part of script that we can add on functions.php and enable google font subsets. Anybody knows how?

@andrejsrna
Copy link

Bump. Need this, please.

@MichaelDarko
Copy link

+1

@arielk arielk added this to the 3.0.0 milestone Aug 21, 2020
@arielk arielk added control/group/typography References the Typography group settings control. status/merged Indicates when a Pull Request has been merged to a Release. labels Aug 21, 2020
@shilo-ey
Copy link
Contributor

This issue has been resolved in Elementor v3.0.0

Feel free to update

Thanks!

@mateitudor
Copy link

It just hasn't been completed for romanian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
control/group/typography References the Typography group settings control. status/merged Indicates when a Pull Request has been merged to a Release.
Projects
None yet
Development

No branches or pull requests

7 participants