Add example of expect(response).to have_http_status(:status_code_name)

[eliotsykes]

Example of using have_http_status method

# Rails `:symbolized` status codes at end of each status code page at http://httpstatus.es/
expect(response).to have_http_status(:success) # 200
expect(response).to have_http_status(:forbidden) # 403

Source: RSpec Controller Specs cheatsheet

[eliotsykes]

Try to get this syntax or similar into request specs too so they're not full of magic numbers

[eliotsykes]

Consider adding expect(page).to have_http_status(:success) to a feature spec. rspec-rails supports this according to README.

[dideler]

Neat, I didn't know about have_http_status 🙇

Some other options you can consider for controller and request specs to avoid magic numbers

• assert_response :ok # From Rails' Action Controller
• expect(response).to be_forbidden # Also from Rails' Action Controller
• it { should respond_with(:unauthorized) } # From Shoulda Matchers

[eliotsykes]

Thanks for the tips @dideler - especially like should respond_with(...) 👍

[eliotsykes]

WIP: have_http_status(...) appearing in #96

[eliotsykes]

Closed by #96