Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registration of ErlangHandler spec mismatch #9330

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Registration of ErlangHandler spec mismatch #9330

merged 1 commit into from
Sep 9, 2019

Conversation

hauleth
Copy link
Contributor

@hauleth hauleth commented Sep 6, 2019

The Dialyzer was issuing a warining on logger:add_handler/3 call as
the key sasl_reports? should not be in root map but rather within
config key of the map.

@hauleth
fix: registration of ErlangHandler spec mismatch
7f322c3 
The Dialyzer was issuing a warining on `logger:add_handler/3` call as
the key `sasl_reports?` should not be in root map but rather within
`config` key of the map.
@fertapric fertapric merged commit 0735f73 into elixir-lang:master Sep 9, 2019
@fertapric
Copy link
Member

Thanks @hauleth! 💜

@hauleth hauleth deleted the fix/erlang_logger-spec-mismatch branch September 9, 2019 21:13
@hauleth
Copy link
Contributor Author

hauleth commented Sep 9, 2019

Funny thing is that #9333 will remove that ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hauleth @fertapric @josevalim