Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support structs in DataTable #33

Merged
merged 3 commits into from
Jul 21, 2021
Merged

Support structs in DataTable #33

merged 3 commits into from
Jul 21, 2021

Conversation

jonatanklosko
Copy link
Member

@jonatanklosko jonatanklosko commented Jul 21, 2021 •
edited
Loading

Closes #32.

image

josevalim
josevalim reviewed Jul 21, 2021
View reviewed changes
lib/kino/data_table.ex Outdated Show resolved Hide resolved
josevalim
josevalim reviewed Jul 21, 2021
View reviewed changes
lib/kino/data_table.ex Outdated Show resolved Hide resolved
josevalim
josevalim reviewed Jul 21, 2021
View reviewed changes
Copy link
Contributor

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments and ship it!

@jonatanklosko jonatanklosko merged commit 73df760 into main Jul 21, 2021
@jonatanklosko jonatanklosko deleted the jk-structs branch July 21, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support structs in data_table
2 participants
@jonatanklosko @josevalim