-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Test Directory for 2 and 3 levels up #89
Comments
Hi, yes that makes sense. Please make a PR and also add a test for it, would be great :) I've refactored quite a bit and added some tests so should be possible to add tests for that as well but you'll need to update the expected count of some current tests probably. You need php and composer on your path then you can run the tests with CI will also run tests when you create a PR. |
Thanks!
|
The prereqs do develop locally should just be:
I dont use a Docker locally I just have the above installed.
You should also be able to debug the extension with F5. There's also a launch setting to debug the tests. Let me know if you run into problems, Im just listing what I believe is needed. |
I added a contribute section to the readme. |
So, in a Docker container it is a pain in the ass so I falled back to Windows. There seems to be a problem with the Docker driver deciding it should run in a docker container though, I had to disable it to run tests. |
Thanks! I merged your PR and pushed a new version on the way out now. Ok too bad the devcontainer didn't work for you, I tried it the day after on another PC and it worked for me. Since inside the devcontainer it has php on the path it should pick that driver and not the docker driver. I could debug as well. Basically just click the button and F5. Guess "works on my machine" didn't go away with docker after all. |
Nothing to worry about. Thank you! |
Hi, since you've been away I've forked the extension to fix my two suggestions and I added two additional commands - "Test Directory [2]" and "Test Directory [3]" which work the same way as "Test Directory", but respectively 2 and 3 levels up from the current file.
I could PR them if you're okay with this or you can do them yourself, but they are really useful since I usually have a pretty deep directory structure for tests - if a class has more tests I tend to split them into separate files and put them in a folder with the name of the class. And so if I want to run all the tests from the class' namespace, I need a filter that is 2 directories up, not one.
I hope that this makes sense.
The text was updated successfully, but these errors were encountered: