Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor architecture to use pydantic #45

Open
bvreede opened this issue Nov 17, 2023 · 1 comment
Open

Refactor architecture to use pydantic #45

bvreede opened this issue Nov 17, 2023 · 1 comment
Assignees

Comments

@bvreede
Copy link
Contributor

bvreede commented Nov 17, 2023

There are a number of limitations to the (data) classes we are using in the current architecture, and especially since we need to flexibly transition between json and our class structure, and want to be flexible to adapt to new analytical methods, I am strongly leaning to applying Pydantic instead of the current architecture.

@carschno can we take some time to explore/implement this together?

@carschno
Copy link
Collaborator

I agree that PyDantic would be a better solution for serialization and deserialization, especially when it comes to validation.
Nevertheless, I think it makes sense to think about the specific limitations of the current implementation regarding data classes and how they specifically affect the required functionality (ie. what would this change fix now or in the future?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants