Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embroider builds failing due to did-intersect-mock #963

Open
elwayman02 opened this issue Oct 11, 2023 · 1 comment
Open

Embroider builds failing due to did-intersect-mock #963

elwayman02 opened this issue Oct 11, 2023 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@elwayman02
Copy link
Owner

            TypeError: Attempted to replace instances which is already replaced
                at eval (webpack://dummy/../../sinon/lib/sinon/sandbox.js?:166:15)
                at Array.forEach (<anonymous>)
                at verifyNotReplaced (webpack://dummy/../../sinon/lib/sinon/sandbox.js?:164:5)
                at Sandbox.replace (webpack://dummy/../../sinon/lib/sinon/sandbox.js?:187:5)
                at mockDidIntersect (webpack://dummy/../rewritten-packages/ember-scroll-modifiers.e10ccf07/test-support/did-intersect-mock.js?:122:9)
                at Object.eval (webpack://dummy/./tests/integration/modifiers/did-intersect-mock-test.js?:20:127)
@elwayman02 elwayman02 added bug Something isn't working help wanted Extra attention is needed labels Oct 11, 2023
@elwayman02
Copy link
Owner Author

Update: This is because the sinon.replace calls don't seem to be cleaned up between tests - maybe we need to try sinon.stub instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant