Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web3 version configuration does not apply to tests #977

Open
danlipert opened this issue Oct 9, 2018 · 0 comments
Open

Web3 version configuration does not apply to tests #977

danlipert opened this issue Oct 9, 2018 · 0 comments

Comments

@danlipert
Copy link
Contributor

Overview

TL;DR
The recent web3 release (beta 36) added a new ABI encoder which breaks some of my previous tests that use BigNumbers as function arguments (web3/web3.js#1936). The configurable version of web3 in embark.json only configures which version of web3 is used within the dapp, but not in the tests. In this case, and possibly more in the future it would be useful to allow configuration of the version of web3 used with embark test.

Extra Detail

Steps to reproduce

  1. set version of web3 in embark.json
  2. examine the version of the web3 object in your tests

Screenshots

Logs

Context (Environment)

  • OS: Mac OS 10.13.3
  • Embark Version: 3.2.2
  • Node Version: 10.7.0
  • NPM Version: 10.7.0

Questions?

  • Leave a comment on this issue! Make sure to use @ mentions if you want a specific person's attention!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants