Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquid Outlet inside Liquid If not working #239

Closed
carrotcomputer opened this issue Apr 6, 2015 · 3 comments
Closed

Liquid Outlet inside Liquid If not working #239

carrotcomputer opened this issue Apr 6, 2015 · 3 comments

Comments

@carrotcomputer
Copy link

I have a liquid outlet nested inside a liquid if (with an else clause):

{{#liquid-if login containerless=true class="inherit-height"}}
  {{liquid-outlet "login" class="inherit-height"}}
{{else}}
<div class="main">
  {{liquid-outlet class="auto-height content-view"}}
</div>
{{/liquid-if}}

Before upgrading to 0.19.2 (up from 0.14.0), this worked fine. Now I get the following error:

Uncaught TypeError: Cannot read property 'render' of undefined

My workaround at the moment, is to change both outlets and ifs to a regular ember equivalents - basically removing all traces of Liquid Fire from the project.

Ember: 1.11.0
Ember CLI: 0.2.2
Liquid Fire: 0.19.2

Any ideas?

@ef4
Copy link
Collaborator

ef4 commented Apr 10, 2015

Thanks. I was able to reproduce the problem. The issue is that a {{liquid-outlet}} that has no content will crash, but only when its parent outlet remains stable since the previous transition.

@carrotcomputer
Copy link
Author

Thank you. Amazing framework btw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@ef4 and others