From 4078963bb366a3a3619f023ad62806a953a354a3 Mon Sep 17 00:00:00 2001 From: Matthew Beale Date: Sat, 4 Dec 2021 16:17:56 -0500 Subject: [PATCH 1/2] Allow console messages --- lib/utils.js | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/utils.js b/lib/utils.js index 8b335622..9c670f6b 100644 --- a/lib/utils.js +++ b/lib/utils.js @@ -166,6 +166,7 @@ function getTemplateCompiler(templateCompilerPath, EmberENV = {}) { let sandbox = { EmberENV: clonedEmberENV, + console, // Older versions of ember-template-compiler (up until ember-source@3.1.0) // eagerly access `setTimeout` without checking via `typeof` first From 5a0bbe52b037453f1dedd0bae4f5e0cd30bf694d Mon Sep 17 00:00:00 2001 From: Matthew Beale Date: Sat, 4 Dec 2021 17:03:57 -0500 Subject: [PATCH 2/2] Update CI for Ember 4.x --- .github/workflows/ci.yml | 4 +--- config/ember-try.js | 23 +++++++++++++++++++++++ 2 files changed, 24 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5fa25aa7..8ca4d2f9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -78,10 +78,8 @@ jobs: - ember-lts-3.8 - ember-lts-3.12 - ember-lts-3.16 - - ember-release + - ember-lts-3.28 - ember-octane - - ember-beta - - ember-canary - ember-default-with-jquery - with-ember-cli-htmlbars-inline-precompile diff --git a/config/ember-try.js b/config/ember-try.js index 6b1d5737..875a1947 100644 --- a/config/ember-try.js +++ b/config/ember-try.js @@ -35,11 +35,24 @@ module.exports = function () { }, }, }, + { + name: 'ember-lts-3.28', + npm: { + devDependencies: { + 'ember-source': '~3.28.0', + }, + }, + }, { name: 'ember-release', npm: { devDependencies: { + 'ember-auto-import': '^2.2.3', 'ember-source': urls[0], + webpack: '^5.52.1', + }, + ember: { + edition: 'octane', }, }, }, @@ -47,7 +60,12 @@ module.exports = function () { name: 'ember-beta', npm: { devDependencies: { + 'ember-auto-import': '^2.2.3', 'ember-source': urls[1], + webpack: '^5.52.1', + }, + ember: { + edition: 'octane', }, }, }, @@ -55,7 +73,12 @@ module.exports = function () { name: 'ember-canary', npm: { devDependencies: { + 'ember-auto-import': '^2.2.3', 'ember-source': urls[2], + webpack: '^5.52.1', + }, + ember: { + edition: 'octane', }, }, },