Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the docs on the third-party-dependencies section to describe dynamic import method #921

Open
mansona opened this issue Jun 7, 2023 · 0 comments

Comments

@mansona
Copy link
Member

mansona commented Jun 7, 2023

The docs for third party dependencies describes a rather old technique that involves automatically wrapping your vendor libs in a "fastboot guard". This method a) won't work for anything that is using ember-auto-import and b) won't work in a broccoli-free embroider build

We should update this section to describe the fact that you can use dynamic imports inline with your code that has a fastboot guard on it. This is idiomatic in terms of the wider JS community i.e. don't import things that you know won't work in your environment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant