Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastBoot should emit metrics #107

Open
kratiahuja opened this issue Jan 6, 2017 · 2 comments
Open

FastBoot should emit metrics #107

kratiahuja opened this issue Jan 6, 2017 · 2 comments

Comments

@kratiahuja
Copy link
Contributor

This issue is an enhancement for future purposes.

Post FastBoot 1.0, we should look at emmitting some useful metrics like server side latency, memory used by the node processes so that apps using FastBoot can listen to these metrics and create useful operational dashboard.

This probably will need an RFC at some point IMO.

@sdhull
Copy link

sdhull commented Feb 8, 2019

notes from discussion in fastboot meeting:

  • would tooling be low-overhead and on all the time?
  • would there be some debugging mode that you can turn on just to debug?
  • are there specific metrics you want?
  • time from when the visit request started to when the promise was resolved
  • when rehydration starts, how long does it take?
  • we're not going to do better than existing node.js tools re: memory leaks & stuff
  • express & node have tooling
  • what kind of unique-to-ember things can we emit?
  • did a rerender get scheduled?
  • did you use a tag that is known to have issues with rehydration? (eg <select> [aside: wait, for real?])

@ryanto has some middlewares for some tooling he might be willing to share...?

@rondale-sc
Copy link
Contributor

I believe in the rehydration builder there is a path that happens when a node is skipped or removed (when the rehydration builder can't decipher something so it throws it out). It would be great to see a counter of that accessible in some sort of debug mode to determine how effective rehydration is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants