Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember 3.27 and/or embroider/test-setup 0.40 breaks ec-addon-docs #830

Closed
elwayman02 opened this issue May 12, 2021 · 3 comments
Closed

Ember 3.27 and/or embroider/test-setup 0.40 breaks ec-addon-docs #830

elwayman02 opened this issue May 12, 2021 · 3 comments
Labels

Comments

@elwayman02
Copy link
Contributor

elwayman02 commented May 12, 2021

Two of my projects using ec-addon-docs are failing to render when deployed, with the same error surfacing when upgrading ember-source to 3.27 or embroider/test-setup to 0.40.

See: emberjs/ember.js#19538 and embroider-build/embroider#805

@elwayman02
Copy link
Contributor Author

Incidentally, my doc sites that don't use ec-addon-docs have not experienced these issues, so something about the way ec-addon-docs is built specifically runs afoul of the bugs introduced in those versions.

@RobbieTheWagner
Copy link
Member

@elwayman02 I believe that ember-modal-dialog is the source of a lot of our embroider woes.

@RobbieTheWagner
Copy link
Member

I think things should be working now, but let me know if they are not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants