From 65462a26cd763bb70af65661c816fdf38a5879a9 Mon Sep 17 00:00:00 2001
From: Jen Weber <j@jenweber.me>
Date: Sun, 19 May 2019 22:58:31 -0400
Subject: [PATCH 1/6] finish up remaining link-to and input conversions

---
 guides/release/routing/redirection.md     |  2 +-
 guides/release/templates/input-helpers.md | 22 +++++++++++-----------
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/guides/release/routing/redirection.md b/guides/release/routing/redirection.md
index 4a16c41dc3..c23124a023 100644
--- a/guides/release/routing/redirection.md
+++ b/guides/release/routing/redirection.md
@@ -10,7 +10,7 @@ Ember allows you to control that access with a combination of hooks and methods
 One of the methods is [`transitionTo()`](https://www.emberjs.com/api/ember/release/classes/Route/methods/transitionTo?anchor=transitionTo).
 Calling `transitionTo()` from a route or
 [`transitionToRoute()`](https://www.emberjs.com/api/ember/release/classes/Controller/methods/transitionToRoute?anchor=transitionToRoute) from a controller will stop any transitions currently in progress and start a new one, functioning as a redirect.
-`transitionTo()` behaves exactly like the [link-to](../../templates/links/) helper.
+`transitionTo()` behaves exactly like the [LinkTo](../../templates/links/) helper.
 
 The other one is [`replaceWith()`](https://www.emberjs.com/api/ember/release/classes/Route/methods/transitionTo?anchor=replaceWith/) which works the same way as `transitionTo()`.
 The only difference between them is how they manage history.
diff --git a/guides/release/templates/input-helpers.md b/guides/release/templates/input-helpers.md
index 1f6b199828..44a6ef6e30 100644
--- a/guides/release/templates/input-helpers.md
+++ b/guides/release/templates/input-helpers.md
@@ -1,12 +1,12 @@
-The [`{{input}}`](https://www.emberjs.com/api/ember/release/classes/Ember.Templates.helpers/methods/if?anchor=input)
-and [`{{textarea}}`](https://www.emberjs.com/api/ember/release/classes/Ember.Templates.helpers/methods/if?anchor=textarea)
+The [`Input`](https://www.emberjs.com/api/ember/release/classes/Ember.Templates.helpers/methods/if?anchor=input)
+and [`textArea`](https://www.emberjs.com/api/ember/release/classes/Ember.Templates.helpers/methods/if?anchor=textarea)
 helpers in Ember.js are the easiest way to create common form controls.
 Using these helpers, you can create form controls that are almost identical to the native HTML `<input>` or `<textarea>` elements, but are aware of Ember's two-way bindings and can automatically update.
 
 ## Text fields
 
 ```handlebars
-{{input value="http://www.facebook.com"}}
+<Input value="http://www.facebook.com" />
 ```
 
 Will become:
@@ -37,7 +37,7 @@ unquoted, these values will be bound to a property on the template's current
 rendering context. For example:
 
 ```handlebars
-{{input type="text" value=this.firstName disabled=this.entryNotAllowed size="50"}}
+<input type="text" value={{this.firstName}} disabled={{this.entryNotAllowed}} size="50" />
 ```
 
 Will bind the `disabled` attribute to the value of `entryNotAllowed` in the
@@ -48,7 +48,7 @@ current context.
 To dispatch an action on specific events such as `key-press`, use the following
 
 ```handlebars
-{{input value=this.firstName key-press=(action "updateFirstName")}}
+<input value={{this.firstName}} key-press={{action "updateFirstName"}} />
 ```
 
 The following event types are supported (dasherized format):
@@ -67,11 +67,11 @@ More [events types](https://www.emberjs.com/api/ember/release/classes/Component)
 ## Checkboxes
 
 You can also use the
-[`{{input}}`](https://www.emberjs.com/api/ember/release/classes/Ember.Templates.helpers/methods/if?anchor=input)
+[`Input`](https://www.emberjs.com/api/ember/release/classes/Ember.Templates.helpers/methods/if?anchor=input)
 helper to create a checkbox by setting its `type`:
 
 ```handlebars
-{{input type="checkbox" name="isAdmin" checked=this.isAdmin}}
+<Input type="checkbox" name="isAdmin" checked={{this.isAdmin}} />
 ```
 
 Checkboxes support the following properties:
@@ -91,19 +91,19 @@ Which can be bound or set as described in the previous section.
 Checkboxes are a special input type. If you want to dispatch an action on a certain [event](https://www.emberjs.com/api/ember/release/classes/Component), you will always need to define the event name in camelCase format:
 
 ```handlebars
-{{input type="checkbox" keyPress=(action "updateName")}}
+<Input type="checkbox" key-press={{action "updateName"}} />
 ```
 
 
 ## Text Areas
 
 ```handlebars
-{{textarea value=this.name cols="80" rows="6"}}
+<Textarea value={{this.name}} cols="80" rows="6" />
 ```
 
 Will bind the value of the text area to `name` on the current context.
 
-[`{{textarea}}`](https://www.emberjs.com/api/ember/release/classes/Ember.Templates.helpers/methods/textarea?anchor=textarea) supports binding and/or setting the following properties:
+[`Textarea`](https://www.emberjs.com/api/ember/release/classes/Ember.Templates.helpers/methods/textarea?anchor=textarea) supports binding and/or setting the following properties:
 
 * `value`
 * `name`
@@ -128,7 +128,7 @@ Will bind the value of the text area to `name` on the current context.
 You might need to bind a property dynamically to an input if you're building a flexible form, for example. To achieve this you need to use the [`{{get}}`](https://www.emberjs.com/api/ember/release/classes/Ember.Templates.helpers/methods/get?anchor=get) and [`{{mut}}`](https://www.emberjs.com/api/ember/release/classes/Ember.Templates.helpers/methods/mut?anchor=mut) in conjunction like shown in the following example:
 
 ```handlebars
-{{input value=(mut (get this.person this.field))}}
+<Input value={{mut (get this.person this.field)}} />
 ```
 
 The `{{get}}` helper allows you to dynamically specify which property to bind, while the `{{mut}}` helper allows the binding to be updated from the input. See the respective helper documentation for more detail.

From e52d2dec1f525c319ddd5d6c842482bea6bc645f Mon Sep 17 00:00:00 2001
From: Jen Weber <j@jenweber.me>
Date: Sun, 19 May 2019 23:08:11 -0400
Subject: [PATCH 2/6] add labels to form inputs #798

---
 guides/release/templates/input-helpers.md | 24 +++++++++++++++--------
 1 file changed, 16 insertions(+), 8 deletions(-)

diff --git a/guides/release/templates/input-helpers.md b/guides/release/templates/input-helpers.md
index 44a6ef6e30..eb8e1baf7c 100644
--- a/guides/release/templates/input-helpers.md
+++ b/guides/release/templates/input-helpers.md
@@ -6,13 +6,15 @@ Using these helpers, you can create form controls that are almost identical to t
 ## Text fields
 
 ```handlebars
-<Input value="http://www.facebook.com" />
+<label for="site">Site URL</label>
+<Input value="http://www.facebook.com" id="site" />
 ```
 
 Will become:
 
 ```html
-<input type="text" value="http://www.facebook.com"/>
+<label for="site">Site URL</label>
+<input type="text" value="http://www.facebook.com" id="site"/>
 ```
 
 You can pass the following standard `<input>` attributes within the input
@@ -37,7 +39,8 @@ unquoted, these values will be bound to a property on the template's current
 rendering context. For example:
 
 ```handlebars
-<input type="text" value={{this.firstName}} disabled={{this.entryNotAllowed}} size="50" />
+<label for="firstname">First Name</label>
+<input type="text" value={{this.firstName}} disabled={{this.entryNotAllowed}} size="50" id="firstname" />
 ```
 
 Will bind the `disabled` attribute to the value of `entryNotAllowed` in the
@@ -48,7 +51,8 @@ current context.
 To dispatch an action on specific events such as `key-press`, use the following
 
 ```handlebars
-<input value={{this.firstName}} key-press={{action "updateFirstName"}} />
+<label for="firstname">First Name</label>
+<input value={{this.firstName}} key-press={{action "updateFirstName" id="firstname"}} />
 ```
 
 The following event types are supported (dasherized format):
@@ -71,7 +75,8 @@ You can also use the
 helper to create a checkbox by setting its `type`:
 
 ```handlebars
-<Input type="checkbox" name="isAdmin" checked={{this.isAdmin}} />
+<label for="is-admin">Admin: </label>
+<Input type="checkbox" name="isAdmin" checked={{this.isAdmin}} id="is-admin"/>
 ```
 
 Checkboxes support the following properties:
@@ -91,14 +96,16 @@ Which can be bound or set as described in the previous section.
 Checkboxes are a special input type. If you want to dispatch an action on a certain [event](https://www.emberjs.com/api/ember/release/classes/Component), you will always need to define the event name in camelCase format:
 
 ```handlebars
-<Input type="checkbox" key-press={{action "updateName"}} />
+<label for="firstname">First Name</label>
+<Input type="checkbox" key-press={{action "updateName"}} id="firstname" />
 ```
 
 
 ## Text Areas
 
 ```handlebars
-<Textarea value={{this.name}} cols="80" rows="6" />
+<label for="firstname">First Name</label>
+<Textarea value={{this.name}} cols="80" rows="6" id="firstname" />
 ```
 
 Will bind the value of the text area to `name` on the current context.
@@ -128,7 +135,8 @@ Will bind the value of the text area to `name` on the current context.
 You might need to bind a property dynamically to an input if you're building a flexible form, for example. To achieve this you need to use the [`{{get}}`](https://www.emberjs.com/api/ember/release/classes/Ember.Templates.helpers/methods/get?anchor=get) and [`{{mut}}`](https://www.emberjs.com/api/ember/release/classes/Ember.Templates.helpers/methods/mut?anchor=mut) in conjunction like shown in the following example:
 
 ```handlebars
-<Input value={{mut (get this.person this.field)}} />
+<label for="firstname">First Name</label>
+<Input value={{mut (get this.person this.field)}} id="firstname" />
 ```
 
 The `{{get}}` helper allows you to dynamically specify which property to bind, while the `{{mut}}` helper allows the binding to be updated from the input. See the respective helper documentation for more detail.

From 809462e27437fb6b71795ada4e2bf43fc1add28b Mon Sep 17 00:00:00 2001
From: Jen Weber <j@jenweber.me>
Date: Tue, 21 May 2019 15:25:28 -0400
Subject: [PATCH 3/6] add missing backticks

---
 guides/release/routing/redirection.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guides/release/routing/redirection.md b/guides/release/routing/redirection.md
index c23124a023..31fac64d95 100644
--- a/guides/release/routing/redirection.md
+++ b/guides/release/routing/redirection.md
@@ -10,7 +10,7 @@ Ember allows you to control that access with a combination of hooks and methods
 One of the methods is [`transitionTo()`](https://www.emberjs.com/api/ember/release/classes/Route/methods/transitionTo?anchor=transitionTo).
 Calling `transitionTo()` from a route or
 [`transitionToRoute()`](https://www.emberjs.com/api/ember/release/classes/Controller/methods/transitionToRoute?anchor=transitionToRoute) from a controller will stop any transitions currently in progress and start a new one, functioning as a redirect.
-`transitionTo()` behaves exactly like the [LinkTo](../../templates/links/) helper.
+`transitionTo()` behaves exactly like the [`LinkTo`](../../templates/links/) helper.
 
 The other one is [`replaceWith()`](https://www.emberjs.com/api/ember/release/classes/Route/methods/transitionTo?anchor=replaceWith/) which works the same way as `transitionTo()`.
 The only difference between them is how they manage history.

From 307995f82ba924ef5bfbc4c6b51308d3d849950c Mon Sep 17 00:00:00 2001
From: Jen Weber <weberj10@gmail.com>
Date: Tue, 21 May 2019 15:40:42 -0400
Subject: [PATCH 4/6] Update guides/release/templates/input-helpers.md

Co-Authored-By: Robert Jackson <me@rwjblue.com>
---
 guides/release/templates/input-helpers.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guides/release/templates/input-helpers.md b/guides/release/templates/input-helpers.md
index eb8e1baf7c..12bb41750d 100644
--- a/guides/release/templates/input-helpers.md
+++ b/guides/release/templates/input-helpers.md
@@ -1,5 +1,5 @@
 The [`Input`](https://www.emberjs.com/api/ember/release/classes/Ember.Templates.helpers/methods/if?anchor=input)
-and [`textArea`](https://www.emberjs.com/api/ember/release/classes/Ember.Templates.helpers/methods/if?anchor=textarea)
+and [`Textarea`](https://www.emberjs.com/api/ember/release/classes/Ember.Templates.helpers/methods/if?anchor=textarea)
 helpers in Ember.js are the easiest way to create common form controls.
 Using these helpers, you can create form controls that are almost identical to the native HTML `<input>` or `<textarea>` elements, but are aware of Ember's two-way bindings and can automatically update.
 

From 21fd8bc5de8a3018062572abfa250ff0373ac299 Mon Sep 17 00:00:00 2001
From: Jen Weber <weberj10@gmail.com>
Date: Tue, 21 May 2019 15:42:07 -0400
Subject: [PATCH 5/6] capitalization

---
 guides/release/templates/input-helpers.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guides/release/templates/input-helpers.md b/guides/release/templates/input-helpers.md
index 12bb41750d..7e97b90b8f 100644
--- a/guides/release/templates/input-helpers.md
+++ b/guides/release/templates/input-helpers.md
@@ -52,7 +52,7 @@ To dispatch an action on specific events such as `key-press`, use the following
 
 ```handlebars
 <label for="firstname">First Name</label>
-<input value={{this.firstName}} key-press={{action "updateFirstName" id="firstname"}} />
+<Input value={{this.firstName}} key-press={{action "updateFirstName" id="firstname"}} />
 ```
 
 The following event types are supported (dasherized format):

From 43bb9e9ba44bde95ff8ee94b4d1b6185a3ca556d Mon Sep 17 00:00:00 2001
From: Robert Jackson <me@rwjblue.com>
Date: Fri, 24 May 2019 11:28:22 -0400
Subject: [PATCH 6/6] Apply suggestions from code review

---
 guides/release/templates/input-helpers.md | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/guides/release/templates/input-helpers.md b/guides/release/templates/input-helpers.md
index 7e97b90b8f..7972e10fc1 100644
--- a/guides/release/templates/input-helpers.md
+++ b/guides/release/templates/input-helpers.md
@@ -52,7 +52,7 @@ To dispatch an action on specific events such as `key-press`, use the following
 
 ```handlebars
 <label for="firstname">First Name</label>
-<Input value={{this.firstName}} key-press={{action "updateFirstName" id="firstname"}} />
+<Input @value={{this.firstName}} @key-press={{action "updateFirstName" id="firstname"}} />
 ```
 
 The following event types are supported (dasherized format):
@@ -76,7 +76,7 @@ helper to create a checkbox by setting its `type`:
 
 ```handlebars
 <label for="is-admin">Admin: </label>
-<Input type="checkbox" name="isAdmin" checked={{this.isAdmin}} id="is-admin"/>
+<Input @type="checkbox" @name="isAdmin" @checked={{this.isAdmin}} id="is-admin"/>
 ```
 
 Checkboxes support the following properties:
@@ -97,7 +97,7 @@ Checkboxes are a special input type. If you want to dispatch an action on a cert
 
 ```handlebars
 <label for="firstname">First Name</label>
-<Input type="checkbox" key-press={{action "updateName"}} id="firstname" />
+<Input @type="checkbox" @key-press={{action "updateName"}} id="firstname" />
 ```
 
 
@@ -105,7 +105,7 @@ Checkboxes are a special input type. If you want to dispatch an action on a cert
 
 ```handlebars
 <label for="firstname">First Name</label>
-<Textarea value={{this.name}} cols="80" rows="6" id="firstname" />
+<Textarea @value={{this.name}} cols="80" rows="6" id="firstname" />
 ```
 
 Will bind the value of the text area to `name` on the current context.
@@ -136,7 +136,7 @@ You might need to bind a property dynamically to an input if you're building a f
 
 ```handlebars
 <label for="firstname">First Name</label>
-<Input value={{mut (get this.person this.field)}} id="firstname" />
+<Input @value={{mut (get this.person this.field)}} id="firstname" />
 ```
 
 The `{{get}}` helper allows you to dynamically specify which property to bind, while the `{{mut}}` helper allows the binding to be updated from the input. See the respective helper documentation for more detail.