Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Foo bar={{baz}}/> fails #10

Closed
Turbo87 opened this issue Jun 5, 2018 · 6 comments · Fixed by emberjs/ember.js#16743
Closed

<Foo bar={{baz}}/> fails #10

Turbo87 opened this issue Jun 5, 2018 · 6 comments · Fixed by emberjs/ember.js#16743

Comments

@Turbo87
Copy link
Contributor

Turbo87 commented Jun 5, 2018

<OpenHomeMobile @platform="ios" @goToMobileSite={{action goToMobileSite}}/>

resulted in Unclosed element 'openHomeMobile' (on line 4).

Adding a space before the /> solved the issue.

@rwjblue
Copy link
Member

rwjblue commented Jun 5, 2018

@Turbo87 - What Ember version? Does the same happen for <div data-blah={{action lol}}/>?

@rwjblue
Copy link
Member

rwjblue commented Jun 5, 2018

Yeah, looks like an issue with glimmer-vm. Transitioning from the mustache state to tag end state seems to require a space...

@Turbo87
Copy link
Contributor Author

Turbo87 commented Jun 5, 2018

This was with [email protected]

@rwjblue
Copy link
Member

rwjblue commented Jun 5, 2018

Ya, but I think it would have the same issue back to 2.10 all the way through current glimmer-vm master. We'll have to fix it over there I think since the error happens before our AST transform has a chance to run...

@Turbo87
Copy link
Contributor Author

Turbo87 commented Jun 5, 2018

yep, that's what I feared. would probably still be good to document it in a "Caveats" section.

@rwjblue
Copy link
Member

rwjblue commented Jun 11, 2018

I created glimmerjs/glimmer-vm#829 to track actually fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants