-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ember-lifeline to use this polyfill #8
Comments
Yep, agreed. I can take a stab at migrating lifeline's internals. |
I seem to be running into a small snag with this.
There may be a TS build ordering issue going on here, as the module alias is registered dynamically via the register script in vendor. I'm debugging, but so far I haven't gotten to the bottom of it. @buschtoens do you know if this works with TS projects that use |
Resolved (temporarily) by adding this module to paths in the tsconfig.json: "paths": {
"dummy/tests/*": ["tests/*"],
"dummy/*": ["tests/dummy/app/*", "app/*"],
"ember-lifeline": ["addon"],
"ember-lifeline/*": ["addon/*"],
"ember-lifeline/test-support": ["addon-test-support"],
"ember-lifeline/test-support/*": ["addon-test-support/*"],
"@ember/destroyable": ["node_modules/ember-destroyable-polyfill"],
"*": ["types/*"]
} |
Ya, we should (once we are able to land the changes in ember-lifeline) document the exact |
Following up on the tsconfig.json changes I made in lifeline to get this to work: I added the following to the
|
Awesome, thanks @scalvert! |
Sent a PR for adding docs for that over in #73 Also since ember-lifeline/ember-lifeline#852 is landed, I'm closing this... |
I'd like to at least spike migrating ember-lifeline to leveraging this polyfill, then we could do the same for ember-concurrency, etc.
/cc @scalvert
The text was updated successfully, but these errors were encountered: