Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing routeWillChange & routeDidChange #1

Open
nickiaconis opened this issue Jun 29, 2017 · 4 comments
Open

Missing routeWillChange & routeDidChange #1

nickiaconis opened this issue Jun 29, 2017 · 4 comments

Comments

@nickiaconis
Copy link

The polyfill presently lacks support for the routeWillChange and routeDidChange events. They are described here in emberjs/rfcs#95. This, at the very least, prevents ember-prefetch from removing private API monkey patches in favor of this polyfill.

@rwjblue
Copy link
Member

rwjblue commented Jun 29, 2017

Yep, this polyfill only currently provides access to methods/properties that do not require the RouteInfo objects (as that work is not yet done).

We should update the README's known limitations section to mention what we haven't implemented yet.

@mansona
Copy link

mansona commented Nov 1, 2020

Hey folks 👋 is there any appetite for someone to do this work? I'm wondering if there is a plan for how you would be able to achieve this as a polyfill and if so then I might be able to take a quick look at it 😄

@rwjblue
Copy link
Member

rwjblue commented Nov 1, 2020

Seems fine to do, but at this point the value is pretty low. There are no supported Ember LTS's that don't already have these events...

@mansona
Copy link

mansona commented Nov 11, 2020

yes that may be true, but it could help people on older versions of Ember on their upgrade path. This came up for an addon that I wanted to upgrade to the new paradigm but didn't want to break backwards compatibility.

Obviously there is limited value but I'm wondering what your opinion on the expected effort might be 🤔 I am happy to dive into this but I haven't had a look at what it would take quite yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants