Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Fragments is failing CI #6790

Closed
runspired opened this issue Nov 22, 2019 · 3 comments
Closed

Model Fragments is failing CI #6790

runspired opened this issue Nov 22, 2019 · 3 comments

Comments

@runspired
Copy link
Contributor

It passes for us because when the smoke-test and the test against commit both fail we don't consider it a regresssion. Based on the CI stack traces it appears the failures may be due to changes in Ember's object model. We should investigate soon.

cc @pzuraq

@runspired
Copy link
Contributor Author

looks like they already investigated and is not object model related: adopted-ember-addons/ember-data-model-fragments#338

The confusing bit is that the smoke-test should run against ember-data 3.5: https://github.com/lytics/ember-data-model-fragments/blob/master/package.json#L50

So I investigated and it appears it does fail, but gets marked as passing: https://github.com/emberjs/data/pull/6784/checks?check_run_id=313187376

Then I remembered we'd set it up as allowed-fail :( https://travis-ci.org/emberjs/data/jobs/614897070?utm_medium=notification&utm_source=github_status

@runspired
Copy link
Contributor Author

We should improve our monitoring of allowed-fail scenarios so that we're always clear on when one is failing and can move it back if it begins passing.

@runspired
Copy link
Contributor Author

closing in favor of #7529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant