Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"octopi" is incorrect #186

Open
lolmaus opened this issue Jun 19, 2019 · 7 comments
Open

"octopi" is incorrect #186

lolmaus opened this issue Jun 19, 2019 · 7 comments

Comments

@lolmaus
Copy link

lolmaus commented Jun 19, 2019

The -us-i forms come from Latin.

The word octopus is of Greek origin. It's Greek plural form is octopodes, but in English the word is commonly pluralized according to English rules: octopuses.

Since so many people fall for this error, some dictionaries mark octopi as a possible pluralization. Nevertheless, we should not support this common mistake.

Both the logic and the readme need to be fixed.

Prooflinks:

@stefanpenner
Copy link
Member

This library aims to be compatible with ruby’s Active-support. So if they have this, we can also change.

@lolmaus
Copy link
Author

lolmaus commented Jun 19, 2019

Well, ActiveSupport has a documentation example that suggests adding octopi as an override: https://github.com/rails/rails/blob/b9ca94caea2ca6a6cc09abaffaad67b447134079/activesupport/lib/active_support/inflector/inflections.rb#L22

@stefanpenner
Copy link
Member

Then I suspect we should leave it as is.

That being said, I’m totally not apposed to a secondary language pack / config option, that has a more actively maintained language list

@stefanpenner
Copy link
Member

the library was Built with this in mind.

@lolmaus
Copy link
Author

lolmaus commented Jun 19, 2019

On the other hand, it has this.

@lolmaus lolmaus closed this as completed Jun 19, 2019
@stefanpenner stefanpenner reopened this Jun 19, 2019
@stefanpenner
Copy link
Member

stefanpenner commented Jun 19, 2019

@lolmaus I just check, it does support octopus -> octopi:

gem install activesupport
irb
irb(main):008:0> require 'active_support/all'
=> true
irb(main):009:0> 'octopus'.pluralize
=> "octopi"

We will totally accept a PR to correct this.

@wifelette
Copy link
Member

@lolmaus Thanks for taking the time to care about the little details like this! From one fellow grammar nerd to another, much appreciated <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants