Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not find module @embroider/macros imported from @ember/legacy-built-in-components/index #10

Open
Gaurav0 opened this issue Nov 23, 2021 · 3 comments

Comments

@Gaurav0
Copy link

Gaurav0 commented Nov 23, 2021

In v0.4.0 when importing in an addon. ember/ember-cli 3.28

@SergeAstapov
Copy link
Contributor

SergeAstapov commented Nov 23, 2021

@Gaurav0 do you have a reproduction? "@embroider/macros": "^0.47.1" is listed in dependencies of this add-on and v3.0.1 had the same dependency so does not seem smth introduced in v4.0.0.

Tried minimal reproduction via

ember addon test && cd test && ember install @ember/legacy-built-in-components
// make edits and add imports in tests/dummy/app/controllers/application.js
ember s

and things just work

@Gaurav0
Copy link
Author

Gaurav0 commented Nov 24, 2021

Thanks for looking into this @SergeAstapov . Here's my branch: https://github.com/secondstreet/ember-material-components-web/tree/repro_legacy_built_ins. I get the error when running ember test. You can see the error here: https://github.com/secondstreet/ember-material-components-web/runs/4313309166?check_suite_focus=true

For some reason I have an entry for @embroider/macros/runtime but not @embroider/macros in requirejs.entries

@void-mAlex
Copy link
Contributor

hello @Gaurav0 is this still happening?
I ran your branch locally and only had one failing test

not ok 1 Chrome 117.0 - [272 ms] - Acceptance | demo: visiting /
---
actual: >
null
stack: >
Error: Element not found when calling click('.toggle-demo-visibility').

and no mention of @embroider/macros

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants