Async behavior outside of a test

[trentmwillis]

Due to the way RSVP is configured in testing environments and the way ember-qunit's adapter works, it is impossible to define RSVP-based async behavior outside of a test.

As an example, if we want to load some assets before the test run (as we do for ember-engines, currently) then you'll get an error, because QUnit.config.current will be undefined at the moment in which you create an RSVP.Promise.

One option is to move that request into the beforeEach hook of the test module, but this is problematic because if you're attempting to preload assets (as in the above case), it is possible that you need to load the asset to prevent one of the other tests from erring out when requiring it.

I have two proposed solutions:

1. Set Ember.testing to false until QUnit.start() is invoked.
2. Configure RSVP from this addon to only use asyncStart/asyncEnd when QUnit.config.current exists.

All of this said, I am a bit confused as to why we configure RSVP at all. I think this pattern is likely masking bad asynchronous tests and should be done away with, if possible.

[rwjblue]

Totally agreed RE: point 1, I'll make the change in ember-test-helpers...

[rwjblue]

emberjs/ember-test-helpers#227 should address

[rwjblue]

@trentmwillis - Do you think the changes in emberjs/ember-test-helpers#227 are enough to close this, or should we also continue to figure out your second proposal as well?

[trentmwillis]

@rwjblue I believe that should fix it

[rwjblue]

Thank you sir!