Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't we get @each to support deep properties? #10430

Closed
simonexmachina opened this issue Feb 12, 2015 · 10 comments
Closed

Can't we get @each to support deep properties? #10430

simonexmachina opened this issue Feb 12, 2015 · 10 comments

Comments

@simonexmachina
Copy link
Contributor

Having a property dependency on [email protected], doesn't work. You need to define barQuzBinding: 'bar.quz'. Can we can get @each to handle this transparently? Or at least throw an exception if a deep property is used.

@mixonic
Copy link
Member

mixonic commented Feb 12, 2015

@aexmachina I think an exception or assert would be best. Deep chaining of observers can perform poorly. We're building Ember 2.0 around the idea that you won't need deep observation in new codebases.

@mmun
Copy link
Member

mmun commented Feb 12, 2015

Our goal is to flesh out the diffing story so that you never need to use @each again, let alone nested @each!

@simonexmachina
Copy link
Contributor Author

simonexmachina commented Feb 12, 2015 via email

@mmun
Copy link
Member

mmun commented Feb 12, 2015

Agreed.

@archaeron
Copy link

yes please 👍

@wagenet
Copy link
Member

wagenet commented Feb 17, 2015

I remember trying to get an assertion in for this a long time ago. It was a huge pain in the butt then and I gave up. I'm not sure if it will have gotten any easier.

@endash
Copy link
Contributor

endash commented Feb 17, 2015

If difficult to impossible to get an assert in-line, maybe a grep-based warning on build would suffice?

@stefanpenner
Copy link
Member

should throw an exception if it isn't supported, as to not confuse users

@rwjblue
Copy link
Member

rwjblue commented Aug 10, 2015

Was talking to @krisselden about this the other day. The recent refactor (for 2.0.0) for @each will unlock the ability to support [email protected].

@rwjblue
Copy link
Member

rwjblue commented Apr 13, 2016

Helpful warning added in #12847.

@rwjblue rwjblue closed this as completed Apr 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants