Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'application' is rendered twice when defined in the router mapping with 1.11.0-beta.3 #10531

Closed
Xylez01 opened this issue Feb 25, 2015 · 2 comments · Fixed by #10533
Closed

Comments

@Xylez01
Copy link

Xylez01 commented Feb 25, 2015

I discovered this strange behaviour that worked previously:

My router looks like this:

Router.map(function() {

    this.resource('application', {path: '/'}, function (){

    });
});

My application.hbs

<h2 id="title">Welcome to Ember.js</h2>

{{outlet}}

The rendered html:

<div id="ember336" class="ember-view">
    <h2 id="title">Welcome to Ember.js</h2>
    <h2 id="title">Welcome to Ember.js</h2>
    <!---->
</div>

I get the feeling that the application resource is always implicit and is not overriden if defined in the router.

jsbin: http://emberjs.jsbin.com/loricutuxa/1/edit

This is working (no double rendering) with 1.11.0-beta.1

@rwjblue
Copy link
Member

rwjblue commented Feb 25, 2015

LOL, double the outlet fun! I think we should make top level application name reserved, similar to basic and array.

@Xylez01
Copy link
Author

Xylez01 commented Feb 25, 2015

I agree, this was fixed by simply removing the application resource defined in the router. +1 for the fast reactions by the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants