Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

classNames="" on a {{link-to}} cause a full app refresh in 1.13.7 and 2.0.0-beta.5 #12039

Closed
chriscareycode opened this issue Aug 10, 2015 · 2 comments

Comments

@chriscareycode
Copy link

If you have a {{link-to}} with classNames= passed such as {{link-to "library.update" classNames="btn btn-primary btn-xs"}} this will cause a full app refresh. Removing classNames= from the {{link-to}} will not trigger the bug. This appears in 1.13.7 and 2.0.0-beta.5. This bug is not seen in 1.13.6 and 2.0.0-beta.4

@chriscareycode chriscareycode changed the title Some but not all {{link-to}} cause a full app refresh in 1.13.7 and 2.0.0-beta.5 classNames="" on a {{link-to}} cause a full app refresh in 1.13.7 and 2.0.0-beta.5 Aug 10, 2015
@rwjblue
Copy link
Member

rwjblue commented Aug 10, 2015

I believe that this is related to #12008. Basically, when specifying classNames today the ember-view class is being removed so the click event isn't properly handled (and the browser does a full refresh).

@cibernox
Copy link
Contributor

I faced this too today. Basically i changed classNames= by class= in my templates. They work the same AFAIK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants