Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binding variable between template and controller seems to be broken #12047

Closed
jrm2k6 opened this issue Aug 11, 2015 · 6 comments
Closed

binding variable between template and controller seems to be broken #12047

jrm2k6 opened this issue Aug 11, 2015 · 6 comments

Comments

@jrm2k6
Copy link

jrm2k6 commented Aug 11, 2015

Updating from 1.13.6 to 1.13.7 seems to break the binding of variables between template and controller.
For example:

template.hbs:

{{input name="email" value=email}}

and declaring a property email on the controller doesn't update the email property of the controller when typing.

Worked just fine with versions below 1.13.7

@jcope2013
Copy link
Contributor

can you post a reproduction using http://ember-twiddle.com/ or http://emberjs.jsbin.com/?

@rwjblue
Copy link
Member

rwjblue commented Aug 11, 2015

Seems to be working here: http://emberjs.jsbin.com/kenoha/edit?html,js,output

@adam-knights
Copy link

Also hit this issue - http://emberjs.jsbin.com/titimu/edit?html,css,js,console,output I believe that shows it - if you toggle back to 1.13.6 the label updates, with 1.13.7 it does not.

@rwjblue
Copy link
Member

rwjblue commented Aug 11, 2015

Changing classNames= to class= should fix the issue.

Likely a duplicate of #12008.

@rwjblue
Copy link
Member

rwjblue commented Aug 11, 2015

(Still a regression though, I'm not saying that this is good 😸 )

@blimmer
Copy link

blimmer commented Aug 11, 2015

I'm able to repro it twiddle, and as @rwjblue suggests, changing classNames to class fixes the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants