-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Named routing substates have never worked for nested routes. #13072
Comments
Priority:
|
Priority:
Error handling:
|
+1 - Please fix this! |
@nathanhammond can you provide an update? I believe when we were going through this on the community Slack, everything was behaving as expected (just that perhaps things are poorly documented / unclear?) |
I'm still writing tests make sure that this works. my current belief is that it is implemented correctly. |
Named routing substates (#3655) haven't ever properly accounted for route nesting. I've forked @machty's original JS Bin from before this feature was introduced to demonstrate broken nested behavior here.
Reproduction:
The last transition shows that navigation between two nested sibling routes does not trigger the global loading state as the "most specific" loading state in the hierarchy. This conflicts with his description in the JS Bin, as well as the docs we had at approximately that time.
According to our documentation the expected behavior is full bubbling, grabbing the leaf-most
error
orloading
substate. This behavior is different again in 2.3+, presumably as a consequence of theowner
s change.I propose (and volunteer) to actually make this behavior match our documentation and function as expected. This is a "breaking" change, but is also a bugfix.
/cc @machty @alexspeller
The text was updated successfully, but these errors were encountered: